linux-kernel - Re: [PATCH] USB: gadget: s3c-hsotg: fix maxpacket size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131001135630.GN1476@radagast>
Date:	Tue, 1 Oct 2013 08:56:30 -0500
From:	Felipe Balbi <balbi@...com>
To:	Robert Baldyga <r.baldyga@...sung.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<b.zolnierkie@...sung.com>, <m.szyprowski@...sung.com>,
	<andrzej.p@...sung.com>
Subject: Re: [PATCH] USB: gadget: s3c-hsotg: fix maxpacket size

Hi,

On Fri, Sep 27, 2013 at 12:31:09PM +0200, Robert Baldyga wrote:
> This patch changes ep maxpacket value from 512 to 1024, becouse it's needed

shouldn't you use 3072 instead to cope with high bandwidth ISO
endpoints ?

> to handle interupt and isochronous endpoints in high-speed mode. This change
> doesn't affect on driver functioning, becouse fifo size (3072) is still enough

s/becouse/because.

> for the maximum transaction payload (3*1024 for high-speed high-bandwidtch
> endpoints).
> 
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> ---
>  drivers/usb/gadget/s3c-hsotg.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 8a9e2c6..0d1dcbd 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -3146,7 +3146,7 @@ static void s3c_hsotg_initep(struct s3c_hsotg *hsotg,
>  
>  	hs_ep->parent = hsotg;
>  	hs_ep->ep.name = hs_ep->name;
> -	hs_ep->ep.maxpacket = epnum ? 512 : EP0_MPS_LIMIT;
> +	hs_ep->ep.maxpacket = epnum ? 1024 : EP0_MPS_LIMIT;
>  	hs_ep->ep.ops = &s3c_hsotg_ep_ops;
>  
>  	/*
> -- 
> 1.7.9.5
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)