linux-kernel - Re: [PATCH] perf session: Fix infinite loop on invalid perf.data file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131001142154.GA31298@gmail.com>
Date:	Tue, 1 Oct 2013 16:21:54 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Namhyung Kim <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, Sonny Rao <sonnyrao@...omium.org>
Subject: Re: [PATCH] perf session: Fix infinite loop on invalid perf.data file


* David Ahern <dsahern@...il.com> wrote:

> On 10/1/13 1:16 AM, Ingo Molnar wrote:
> >Just a detail: it would be nice to make all the user facing messages in
> >tools/perf/util/header.c more specific and more structured. For example
> >prefixing it with 'perf header:' would be fine:
> >
> >	WARNING: perf/header: Data size is 0. Was the 'perf record' command properly terminated?
> >
> 
> Why put code references in the messages? The message is all on one
> line so grep finds it quickly for people working on the code.

I'd agree if this was some internal error that should never really trigger 
(so at most developers see it).

But if I understood it correctly this particular message could trigger for 
regular users of perf as well, of the perf record is terminated in some 
unusual fashion. Regular users might not have the perf code handy (and 
might not know about git grep either).

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/