linux-kernel - Re: [PATCH] xfs: Use kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Oct 2013 10:00:43 -0500
From:	Mark Tinguely <tinguely@....com>
To:	Thierry Reding <thierry.reding@...il.com>
CC:	Ben Myers <bpm@....com>, Alex Elder <elder@...nel.org>,
	linux-kernel@...r.kernel.org, xfs@....sgi.com
Subject: Re: [PATCH] xfs: Use kmem_free() instead of free()

On 10/01/13 09:47, Thierry Reding wrote:
> This fixes a build failure caused by calling the free() function which
> does not exist in the Linux kernel.
>
> Signed-off-by: Thierry Reding<treding@...dia.com>
> ---
>   fs/xfs/xfs_log_recover.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index 4324058..3979749 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
>   		"bad number of regions (%d) in inode log format",
>   				  in_f->ilf_size);
>   			ASSERT(0);
> -			free(ptr);
> +			kmem_free(ptr);
>   			return XFS_ERROR(EIO);
>   		}
>

Looks good. I will remove the other list items in another patch.

Reviewed-by: Mark Tinguely <tinguely@....com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/