linux-kernel - Re: [PATCH] regulator: tps65090: remove usage of IS_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKDJKT7m0d=GqFF_QTOQitBRac=UZYEaZi5L1xEggM-cp9c85w@mail.gmail.com>
Date:	Tue, 1 Oct 2013 22:02:37 +0530
From:	Manish Badarkhe <badarkhe.manish@...il.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Mark Brown <broonie@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-tegra@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	rmk+kernel@....linux.org.uk
Subject: Re: [PATCH] regulator: tps65090: remove usage of IS_ERR_OR_NULL

Hi Stephan,

Thank you for your reply.

On Tue, Oct 1, 2013 at 9:19 PM, Stephen Warren <swarren@...dotorg.org> wrote:
> On 10/01/2013 08:59 AM, Manish Badarkhe wrote:
>> Hi Mark,
>>
>> Thank you for your reply.
>>
>> On Tue, Oct 1, 2013 at 2:52 PM, Mark Brown <broonie@...nel.org> wrote:
>>> On Tue, Oct 01, 2013 at 09:41:04AM +0530, Manish Badarkhe wrote:
>>>> This patch changes the driver to avoid the usage of IS_ERR_OR_NULL()
>>>> macro.
>>>
>>> Why?
>>
>> Code use "IS_ERR_OR_NULL()" properly as per current implementation. But
>> as per patches [1], [2] below, the use of "IS_ERR_OR_NULL()" has been
>> deprecated.
>> Hence done this change.
>
> The intent was to deprecate to *concept* of checking a return value for
> both NULL and an error. Simply removing usage of the macro and replacing
> it with the exact same code that was part of the macro doesn't fulfil
> the intent at all.

Ok, Please drop this patch.

Regards
Manish Badarkhe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/