lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 01 Oct 2013 12:31:04 -0600 From: Stephen Warren <swarren@...dotorg.org> To: Thierry Reding <thierry.reding@...il.com> CC: Rob Herring <rob.herring@...xeda.com>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Tony Lindgren <tony@...mide.com>, Eric Miao <eric.y.miao@...il.com>, Haojian Zhuang <haojian.zhuang@...il.com>, Ben Dooks <ben-linux@...ff.org>, Kukjin Kim <kgene.kim@...sung.com>, Simon Horman <horms@...ge.net.au>, Magnus Damm <magnus.damm@...il.com>, Guan Xuetao <gxt@...c.pku.edu.cn>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org, openezx-devel@...ts.openezx.org, linux-samsung-soc@...r.kernel.org, linux-sh@...r.kernel.org, linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field On 09/23/2013 03:41 PM, Thierry Reding wrote: > The GPIO API defines 0 as being a valid GPIO number, so this field needs > to be initialized explicitly. > static void __init smdkv210_map_io(void) > @@ -70,6 +70,7 @@ static struct samsung_bl_drvdata samsung_dfl_bl_data __initdata = { > .max_brightness = 255, > .dft_brightness = 255, > .pwm_period_ns = 78770, > + .enable_gpio = -1, > .init = samsung_bl_init, > .exit = samsung_bl_exit, > }, > @@ -121,6 +122,10 @@ void __init samsung_bl_set(struct samsung_bl_gpio_info *gpio_info, > samsung_bl_data->lth_brightness = bl_data->lth_brightness; > if (bl_data->pwm_period_ns) > samsung_bl_data->pwm_period_ns = bl_data->pwm_period_ns; > + if (bl_data->enable_gpio) > + samsung_bl_data->enable_gpio = bl_data->enable_gpio; > + if (bl_data->enable_gpio_flags) > + samsung_bl_data->enable_gpio_flags = bl_data->enable_gpio_flags; Won't this cause the core pwm_bl driver to request/manipulate the GPIO, whereas this driver already does that inside the samsung_bl_init/exit callbacks? I think you either need to adjust those callbacks, or not set the new standard GPIO property in samsung_bl_data. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists