linux-kernel - Re: [PATCH] ll_temac: Reset dma descriptors on ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130930.212153.531876068589922786.davem@davemloft.net>
Date:	Mon, 30 Sep 2013 21:21:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ricardo.ribalda@...il.com
Cc:	joe@...ches.com, jg1.han@...sung.com, gregkh@...uxfoundation.org,
	wfp5p@...ginia.edu, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ll_temac: Reset dma descriptors on ndo_open

From: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Date: Fri, 27 Sep 2013 13:24:28 +0200

> The dma descriptors are only initialized on the probe function.
> 
> If a packet is on the buffer when temac_stop is called, the dma
> descriptors can be left on a incorrect status where no other package can
> be sent.
> 
> So an interface could be left in an usable state after ifdow/ifup.
> 
> This patch makes sure that the descriptors are in a proper status when
> the device is started.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>

This analysis is not correct.

In the current driver, the descriptors are allocated and initialized
in the open function, not the probe function.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/