lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1380653008.1924.10.camel@joe-AO722>
Date:	Tue, 01 Oct 2013 11:43:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	OS Engineering <osengineering@...c-inc.com>
Cc:	"axboe@...nel.dk" <axboe@...nel.dk>,
	Akhil Bhansali <Akhil.Bhansali@...t.com>,
	"jmoyer@...hat.com" <jmoyer@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Amit Phansalkar <Amit.Phansalkar@...t.com>,
	Ramprasad Chinthekindi <Ramprasad.Chinthekindi@...t.com>
Subject: Re: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters

On Tue, 2013-10-01 at 12:29 +0000, OS Engineering wrote:
> From 6ff5102b3cd8047bb4bfb4d0165f289249e23bbe Mon Sep 17 00:00:00 2001
> From: rchinthekindi <rchinthekindi@...c-inc.com>
> Date: Tue, 1 Oct 2013 17:49:58 +0530
> Subject: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
> 
> Restricted pr_debug() lines to 80 characters

Please don't split formats across multiple lines.

> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c


> @@ -2370,9 +2372,10 @@ static void skd_complete_internal(struct skd_device *skdev,
>  			skd_send_internal_skspcl(skdev, skspcl, WRITE_BUFFER);
>  		else {
>  			if (skdev->state == SKD_DRVR_STATE_STOPPING) {
> -				pr_debug("%s:%s:%d TUR failed, don't send anymore"
> -					 "state 0x%x\n",
> -					 skdev->name, __func__, __LINE__, skdev->state);
> +				pr_debug("%s:%s:%d TUR failed, don't send"
> +					 " anymore state 0x%x\n",
> +					 skdev->name, __func__, __LINE__,
> +					 skdev->state);

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ