lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Oct 2013 17:03:48 -0400 From: Tejun Heo <tj@...nel.org> To: Helge Deller <deller@....de> Cc: Libin <huawei.libin@...wei.com>, linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org, James Bottomley <James.Bottomley@...senPartnership.com> Subject: Re: [PATCH] [workqueue] check values of pwq and wq in print_worker_info() before use On Tue, Oct 01, 2013 at 10:53:31PM +0200, Helge Deller wrote: > So, in summary my patch here is not really necessary, but for the sake of > clean code I think it doesn't hurt either and as such it would be nice if > you could apply it. What? function *must* take any value and try to access it and not cause failure. That's the *whole* purpose of that interface. How is having incomplete spurious checks around it "clean code" in any sense of the word? That doesn't make any sense. Nacked-by: Tejun Heo <tj@...nel.org> and *please* don't add any checks like that anywhere else in the kernel. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists