linux-kernel - Re: [PATCH] perf tools: Speed up git-version test on re-make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pprom73p.fsf@sejong.aot.lge.com>
Date:	Wed, 02 Oct 2013 17:04:26 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Ahern <dsahern@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH] perf tools: Speed up git-version test on re-make

On Wed, 2 Oct 2013 08:50:42 +0200, Ingo Molnar wrote:
> * Namhyung Kim <namhyung@...nel.org> wrote:
>
>> On Tue, 1 Oct 2013 16:46:18 +0200, Ingo Molnar wrote:
>> 
>> [SNIP]
>> >  
>> > -$(OUTPUT)PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE
>> > +$(OUTPUT)PERF-VERSION-FILE: ../../.git/HEAD
>> >  	@$(SHELL_PATH) util/PERF-VERSION-GEN $(OUTPUT)
>> > +	@touch $(OUTPUT)PERF-VERSION-FILE
>> >  
>> >  CC = $(CROSS_COMPILE)gcc
>> >  AR = $(CROSS_COMPILE)ar
>> > @@ -813,7 +814,17 @@ clean: $(LIBTRACEEVENT)-clean $(LIBLK)-c
>> >  	$(RM) $(OUTPUT)util/*-flex*
>> >  	$(python-clean)
>> >  
>> > +#
>> > +# Trick: if ../../.git does not exist - we are building out of tree for example,
>> > +# then force version regeneration:
>> > +#
>> > +ifeq ($(wildcard ../../.git/HEAD),) 
>> > +    GIT-HEAD-PHONY = ../../.git/HEAD
>> > +else 
>> > +    GIT-HEAD-PHONY =
>> > +endif
>> > +
>> >  .PHONY: all install clean strip $(LIBTRACEEVENT) $(LIBLK)
>> >  .PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell
>> > -.PHONY: .FORCE-PERF-VERSION-FILE TAGS tags cscope .FORCE-PERF-CFLAGS
>> > +.PHONY: $(GIT-HEAD-PHONY) TAGS tags cscope .FORCE-PERF-CFLAGS
>> >  
>> 
>> I found an unrelated bug.  When I tried to build perf out of tree after 
>> 'make perf-targz-src-pkg' it cannot get any version number.
>> 
>>       GEN common-cmds.h
>>       * new build flags or prefix
>>   make[1]: *** No rule to make target `kernelversion'.  Stop.
>>   PERF_VERSION = 
>>       ...
>>       AR libperf.a
>>       LINK perf
>> 
>>   $ ./perf --version
>>   perf version 
>
> Is this unrelated to my patches?

Yes, I can reproduce it without your patch.

>
>> It looks like we should save and pass the result of 'make kernelversion' 
>> to the tarball.
>
> Or we could simply generate PERF-VERSION-FILE and save it into the 
> tarball?
>
> Then it will be the most accurate version we can determine at the point 
> when the tarball is generated.

Hmm.. I tried to do it, but it's not that simple than I thought.  With
your patch, the PERF-VERSION-FILE is regenerated everytime if it can't
find .git/HEAD so saving the file didn't help since it'll be
overwritten.  Anyway, it also cannot be used with 'make O=...' build.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/