linux-kernel - Re: [PATCH v3 04/10] ARM: OMAP2+: usb-host: Adapt to USB phy-nop RESET line changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <524BF354.3000502@ti.com>
Date:	Wed, 2 Oct 2013 13:20:04 +0300
From:	Roger Quadros <rogerq@...com>
To:	<tony@...mide.com>
CC:	Roger Quadros <rogerq@...com>, <balbi@...com>,
	<bcousson@...libre.com>, <p.zabel@...gutronix.de>,
	<broonie@...nel.org>, <linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 04/10] ARM: OMAP2+: usb-host: Adapt to USB phy-nop
 RESET line changes

Hi Tony,

On 09/24/2013 11:53 AM, Roger Quadros wrote:
> The USB phy-nop nop driver expects the RESET line information
> to be sent as a GPIO number via platform data. Adapt to that.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>

Need your Ack on this one as well.

cheers,
-roger

> ---
>  arch/arm/mach-omap2/usb-host.c |   11 +----------
>  1 files changed, 1 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
> index 78ac1c2..10855eb 100644
> --- a/arch/arm/mach-omap2/usb-host.c
> +++ b/arch/arm/mach-omap2/usb-host.c
> @@ -460,8 +460,7 @@ int usbhs_init_phys(struct usbhs_phy_data *phy, int num_phys)
>  		memset(&nop_pdata, 0, sizeof(nop_pdata));
>  		if (gpio_is_valid(phy->vcc_gpio))
>  			nop_pdata.needs_vcc = true;
> -		if (gpio_is_valid(phy->reset_gpio))
> -			nop_pdata.needs_reset = true;
> +		nop_pdata.gpio_reset = phy->reset_gpio;
>  		nop_pdata.type = USB_PHY_TYPE_USB2;
>  
>  		/* create a NOP PHY device */
> @@ -483,14 +482,6 @@ int usbhs_init_phys(struct usbhs_phy_data *phy, int num_phys)
>  
>  		usb_bind_phy("ehci-omap.0", phy->port - 1, phy_id);
>  
> -		/* Do we need RESET regulator ? */
> -		if (gpio_is_valid(phy->reset_gpio)) {
> -			scnprintf(rail_name, MAX_STR,
> -					"hsusb%d_reset", phy->port);
> -			usbhs_add_regulator(rail_name, phy_id, "reset",
> -						phy->reset_gpio, 1);
> -		}
> -
>  		/* Do we need VCC regulator ? */
>  		if (gpio_is_valid(phy->vcc_gpio)) {
>  			scnprintf(rail_name, MAX_STR, "hsusb%d_vcc", phy->port);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/