linux-kernel - Re: [PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmap based voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131002112822.GB27287@sirena.org.uk>
Date:	Wed, 2 Oct 2013 12:28:22 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Michael Grzeschik <mgr@...gutronix.de>
Cc:	Axel Lin <axel.lin@...ics.com>,
	David Dajun Chen <dchen@...semi.com>,
	Ashish Jangam <ashish.jangam@...tcummins.com>,
	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmap
 based voltage_sel operations

On Wed, Oct 02, 2013 at 12:15:00PM +0200, Michael Grzeschik wrote:

> we should not play to much with generous functions for this pmics. With this
> patch we loose the fix_io code path from da9052_reg_update.

> I suggest that Mark queue the revert of this patch.

This seems far too obscure to be robust - if we need to bodge all I2C
I/O (which is what that looks like) then that should be being done in
the regmap for the device rather than by having stuff open coded in the
function drivers like this.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)