linux-kernel - Re: FW: [PATCH] hidraw: close underlying device at removal of last reader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1310021702330.29701@pobox.suse.cz>
Date:	Wed, 2 Oct 2013 17:02:45 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Manoj Chourasia <mchourasia@...dia.com>
Cc:	"Mika Westerberg (mika.westerberg@...ux.intel.com)" 
	<mika.westerberg@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: FW: [PATCH] hidraw: close underlying device at removal of last
 reader

On Tue, 1 Oct 2013, Manoj Chourasia wrote:

> Hi Jiri,
> 
> Mika Westerberg mika.westerberg@...ux.intel.com reported a bug introduced in hid driver after 
> commit 212a871a393 (HID: hidraw: correctly deallocate memory on device disconnect) 
> that hidraw doesn't close the underlying hid device when the device node is closed last time.
> 
> I am proposing following patch as fix.  Please review it.  Mika will help in testing.
> 
> ----------------------------------------
> >From b37519b65be0d51b90c5fc177c0dc0cd2f6358b1 Mon Sep 17 00:00:00 2001
> From: Manoj Chourasia <mchourasia@...dia.com>
> Date: Tue, 1 Oct 2013 15:39:00 +0530
> Subject: [PATCH] HID: hidraw: close underlying device at removal of last reader
> 
> Even though device exist bit is set the underlying
> HW device should be closed when the last reader
> of the device is closed i.e. open count drops to zero.
> 
> Signed-off-by: Manoj Chourasia <mchourasia@...dia.com>

Applied, thanks a lot to both of you.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/