linux-kernel - Re: [PATCH] Staging : android: binder.c: Prefer seq_puts to seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380680377.2081.27.camel@joe-AO722>
Date:	Tue, 01 Oct 2013 19:19:37 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mathieu Rhéaume <mathieu@...ingrhemes.com>
Cc:	gregkh@...uxfoundation.org, arve@...roid.com,
	dan.carpenter@...cle.com, mirsal@...sal.fr,
	serban.constantinescu@....com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging : android: binder.c: Prefer seq_puts to
 seq_printf

On Tue, 2013-10-01 at 21:57 -0400, Mathieu Rhéaume wrote:
> This patch changes seq_printf for seq_puts in binder.c.
> It fixes the warnings emitted by checkpatch.pl.

Please realign function argument to the open parenthesis.

> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -3272,7 +3272,7 @@ binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer)
>  static void print_binder_transaction(struct seq_file *m, const char *prefix,
>  				     struct binder_transaction *t)
>  {
> -	seq_printf(m,
> +	seq_puts(m,
>  		   "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",
>  		   prefix, t->debug_id, t,
>  		   t->from ? t->from->proc->pid : 0,

This should be
	seq_puts(m, "%s..."
		 prefix, etc...

using two tabs then 1 space to align to open parenthesis

> @@ -3287,7 +3287,7 @@ static void print_binder_transaction(struct seq_file *m, const char *prefix,
>  	if (t->buffer->target_node)
>  		seq_printf(m, " node %d",
>  			   t->buffer->target_node->debug_id);
> -	seq_printf(m, " size %zd:%zd data %p\n",
> +	seq_puts(m, " size %zd:%zd data %p\n",
>  		   t->buffer->data_size, t->buffer->offsets_size,

	seq_puts(m, " size...",
		 t->buffer->etc...

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/