linux-kernel - Re: [PATCH 3/4] kconfig: adjust warning message for conflicting types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1310012230090.5682@chino.kir.corp.google.com>
Date:	Tue, 1 Oct 2013 22:33:48 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Martin Walch <walch.martin@....de>
cc:	Michal Marek <mmarek@...e.cz>, Jiri Kosina <trivial@...nel.org>,
	"Yann E. MORIN" <yann.morin.1998@...e.fr>,
	Arve Hjønnevåg <arve@...roid.com>,
	Benjamin Poirier <bpoirier@...e.de>,
	Dirk Gouders <dirk@...ders.net>,
	Wang YanQing <udknight@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jean Delvare <jdelvare@...e.de>,
	Kees Cook <keescook@...omium.org>,
	Alan Cox <alan@...ux.intel.com>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] kconfig: adjust warning message for conflicting
 types

On Wed, 2 Oct 2013, Martin Walch wrote:

> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index b970101..e511df5 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -119,7 +119,7 @@ void menu_set_type(int type)
>  		sym->type = type;
>  		return;
>  	}
> -	menu_warn(current_entry, "type of '%s' redefined from '%s' to '%s'",
> +	menu_warn(current_entry, "type of '%s' not redefined from '%s' to '%s'",
>  	    sym->name ? sym->name : "<choice>",
>  	    sym_type_name(sym->type), sym_type_name(type));
>  }

The warning is stating that the symbol was attempted to be redefined from 
one type to another, not that it was successful, so I don't think this 
patch actually helps make anything clearer.  (gcc warns when a symbol is 
redefined by saying "redefintion of `blah`".)  Perhaps include that the 
redefinition was ignored?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/