linux-kernel - Re: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Oct 2013 00:08:49 +0300
From:	Taras Kondratiuk <taras.kondratiuk@...aro.org>
To:	Kim Phillips <kim.phillips@...aro.org>
Cc:	sameo@...ux.intel.com, lee.jones@...aro.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linaro Networking <linaro-networking@...aro.org>,
	d.xie@....samsung.com
Subject: Re: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler

On 2 October 2013 19:43, Kim Phillips <kim.phillips@...aro.org> wrote:
> On Wed,  2 Oct 2013 14:08:44 +0300
> Taras Kondratiuk <taras.kondratiuk@...aro.org> wrote:
>
>> From: Danke Xie <d.xie@....samsung.com>
>>
>> The current TWL 6030 IRQ handler assumes little endianness.
>> This change makes it endian-neutral.
>>
>> Signed-off-by: Danke Xie <d.xie@....samsung.com>
>> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@...aro.org>
>> ---
>
> this patch causes a new sparse warning:
>
> make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o
> ...
>   CHECK   drivers/mfd/twl6030-irq.c
> drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32
>
> does int_sts in the sts union need to be defined as __le32?

You are right.
I will update the patch.

-- 
Regards,
Taras Kondratiuk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/