linux-kernel - Re: [PATCH] Staging : android: binder.c: Prefer seq_puts to seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Oct 2013 23:35:38 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ryan Mallon <rmallon@...il.com>
Cc:	Mathieu Rhéaume <mathieu@...ingrhemes.com>,
	gregkh@...uxfoundation.org, arve@...roid.com,
	dan.carpenter@...cle.com, mirsal@...sal.fr,
	serban.constantinescu@....com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging : android: binder.c: Prefer seq_puts to
 seq_printf

On Wed, 2013-10-02 at 15:15 +1000, Ryan Mallon wrote:
> On 02/10/13 11:57, Mathieu Rhéaume wrote:
> > This patch changes seq_printf for seq_puts in binder.c.
> > It fixes the warnings emitted by checkpatch.pl.
[]
> Umm, this won't compile. seq_puts() is defined as:
> 
>   int seq_puts(struct seq_file *m, const char *s);
> 
> checkpatch.pl does indeed complain about uses of seq_printf() in
> drivers/staging/android/binder.c which are passing formatted strings. At
> a quick glance it looks like checkpatch.pl is only checking for the
> format string on the same line as seq_printf(), so this files ugly
> coding style confuses the check. Joe?

True.

This patch should have fixed it.  It's in -next already.

https://lkml.org/lkml/2013/9/13/698

> Anyway, please don't blindly change things in the kernel without at
> least compile testing them.

Yes, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/