linux-kernel - Re: [PATCH 4/4] kconfig: remove unused definition from scanner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201310020857.54800.yann.morin.1998@free.fr>
Date:	Wed, 2 Oct 2013 08:57:54 +0200
From:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
To:	Dirk Gouders <dirk@...ders.net>
Cc:	Martin Walch <walch.martin@....de>, Michal Marek <mmarek@...e.cz>,
	Jiri Kosina <trivial@...nel.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Benjamin Poirier <bpoirier@...e.de>,
	Wang YanQing <udknight@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jean Delvare <jdelvare@...e.de>,
	Kees Cook <keescook@...omium.org>,
	Alan Cox <alan@...ux.intel.com>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] kconfig: remove unused definition from scanner

Martin, All,

On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> Martin Walch <walch.martin@....de> writes:
> 
> > From: Martin Walch <walch.martin@....de>
> > Date: Wed, 2 Oct 2013 06:58:46 +0200
> > Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
> >
> > The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
> 
> Hi Martin,
> 
> I think you should also regenerate the scanner and add
> the new zconf.lex.c_shipped to this patch.

I think sending the re-generated parser as a separate patch helps
in reviewing. Ie. I'd prefer a fifth patch.

BTW, regenerating the parser can be done with:
    make REGENERATE_PARSERS=1 config

Regards,
Yann E. MORIN.

> > Signed-off-by: Martin Walch <walch.martin@....de>
> > ---
> >  scripts/kconfig/zconf.l | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
> > index 6555a47..1a9f53e 100644
> > --- a/scripts/kconfig/zconf.l
> > +++ b/scripts/kconfig/zconf.l
> > @@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
> >  }
> >  %}
> >  
> > -ws	[ \n\t]
> >  n	[A-Za-z0-9_]
> >  
> >  %%
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< O_o >==-- '------------.-------:  X  AGAINST      |  /e\  There is no  |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL    |  """  conspiracy.  |
'------------------------------'-------'------------------'--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/