linux-kernel - Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpon=PO+U2DGJQJKa+9MhxoVC3ALnJYjv8_DEUDMivGZREQ@mail.gmail.com>
Date:	Thu, 3 Oct 2013 10:07:55 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

On 28 September 2013 17:38, Sachin Kamat <sachin.kamat@...aro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.

of_match_ptr() isn't a data structure.. And also what does "protects" mean here?

> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/pinctrl/spear/pinctrl-plgpio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
> index 0a7f0bdb..ff2940e 100644
> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
>                 .owner = THIS_MODULE,
>                 .name = "spear-plgpio",
>                 .pm = &plgpio_dev_pm_ops,
> -               .of_match_table = of_match_ptr(plgpio_of_match),
> +               .of_match_table = plgpio_of_match,
>         },
>  };

Patch is okay otherwise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/