linux-kernel - Re: [pchecks v2 2/2] percpu: Add preemption checks to __this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131003072603.GB5775@gmail.com>
Date:	Thu, 3 Oct 2013 09:26:03 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Tejun Heo <tj@...nel.org>, akpm@...uxfoundation.org,
	linux-arch@...r.kernel.org, Steven Rostedt <srostedt@...hat.com>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu ops

* Christoph Lameter <cl@...ux.com> wrote:

> > > That is exactly what this patch does. There will only be warning if 
> > > the user enabled them.
> >
> > You didn't understand me apparently: all warnings that trigger with 
> > the debug CONFIG option enabled must be fixed before this can be sent 
> > upstream.
> 
> This patchset is required to determine the warnings that will be 
> triggered and to get the work to address these issues done. The feedback 
> so far indicates that there may be lots of discussions regarding the 
> warnings that have been discovered so far. Its not realistic to do this 
> in one go.

Please submit them once you had the time to ensure that they are ready and 
produce no warnings on your system(s) with debugging enabled.

To help out I can stage them for you in a branch within the scheduler tree 
if you think there are spurious warnings - as long as you fix and address 
any bug reports and review feedback received in a timely fashion. I'll 
send it upstream once the debug code has settled down and doesn't produce 
false warnings.

Also, just to make it clear, as I mentioned it in my previous mail: until 
the debug code becomes upstream worthy and converge, consider all your 
__this_cpu patches NAK-ed by me.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/