linux-kernel - Re: [PATCH] perf tool: report user-friendly error from timechart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131003130955.GA27835@gmail.com>
Date:	Thu, 3 Oct 2013 15:09:55 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Ramkumar Ramachandra <artagnon@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH] perf tool: report user-friendly error from timechart


* Ramkumar Ramachandra <artagnon@...il.com> wrote:

> Ingo Molnar wrote:
> >> +     /* Perform a quick sanity check */
> >> +     if (!is_valid_tracepoint("power:cpu_frequency")) {
> >> +             fprintf(stderr, "Error:\tNo permissions to read $debugfs/tracing/events/power/cpu_frequency\n");
> >> +             fprintf(stderr, "Hint:\tChange the permissions of debugfs: /sys/kernel/debug\n");
> >> +             fprintf(stderr, "\tThe directory will be present if your kernel was compiled with debugfs support.\n");
> >
> > Is missing permissions the only way how is_valid_tracepoint() can fail?
> >
> > What if debugfs has the right permissions but CONFIG_TRACEPOINTS is
> > disabled in the kernel?
> 
> I'm thinking about all this in terms of files present in debugfs. Will 
> the cpu_frequecy file be present if tracepoints is disabled? (should I 
> quickly check using User-Mode Linux?). If it won't be present, then we 
> can just change the last line to "compiled with debugfs and tracepoints 
> support".

The debug/tracing/events directory won't be present if tracing is 
disabled.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/