linux-kernel - Re: [PATCH 2/2] fs/ext4/namei.c: reducing contention on s_orphan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <524D2B77.7090006@hp.com>
Date:	Thu, 03 Oct 2013 02:31:51 -0600
From:	Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@...com>
To:	T Makphaibulchoke <tmac@...com>, tytso@....edu,
	adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org, aswin@...com, aswin_proj@...ts.hp.com
Subject: Re: [PATCH 2/2] fs/ext4/namei.c: reducing contention on s_orphan_lock
 mmutex

On 10/02/2013 08:05 PM, Zheng Liu wrote:
> Hello,
> 

>> -	if (!EXT4_SB(sb)->s_journal)
>> +	if (ext4_sb->s_journal)
>         ^^^^^^^^
>         typo: !ext4_sb->s_journal
> I am not sure whether or not this will impact the result because when
> journal is enabled the inode will not be added into orphan list.
> 
> Regards,
>                                                 - Zheng
> 
Thanks Zheng for pointing out the problem.  Will fix the problem and rerun the test.

Thanks,
Mak.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/