linux-kernel - Re: [PATCH v3] mfd: arizona: Correct handling of device tree gpio defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131003154908.GS9048@lee--X1>
Date:	Thu, 3 Oct 2013 16:49:08 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mfd: arizona: Correct handling of device tree gpio
 defaults

On Thu, 03 Oct 2013, Charles Keepax wrote:

> When setting GPIO defaults we are required to make a distinction
> between writing 0x0000 to the registers and leaving them untouched.
> 
> When we receive between 0x0000 and 0xFFFF (inclusive) from either
> Platform Data or Device Tree, we should write the provided
> configuration to the device. Conversely, when we receive >0xFFFF we
> should leave the device configuration at its default setting.
> 
> This patch fixes a bug and ensures that configuration 0x0000 isn't
> mistakenly written when the intention was to keep the default one.
> 
> Reported-by: Heather Lomond <heather.lomond@...fsonmicro.com>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
> 
> Hi,
> 
> Sorry, your explanation is certainly fine with me.
> 
> Thanks,
> Charles
> 
>  drivers/mfd/arizona-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks Charles.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/