linux-kernel - Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo7fzSNGShWocpLQf6LwQZ84u+9zRX0oMJyNrRfe+87mxg@mail.gmail.com>
Date:	Thu, 3 Oct 2013 13:21:22 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Joerg Roedel <joro@...tes.org>,
	Andy Lutomirski <luto@...capital.net>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
Subject: Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning

On Thu, Oct 3, 2013 at 11:21 AM, Neil Horman <nhorman@...driver.com> wrote:
> On Fri, Sep 27, 2013 at 12:53:35PM -0400, Neil Horman wrote:
>> The warning for the irq remapping broken check in intel_irq_remapping.c is
>> pretty pointless.  We need the warning, but we know where its comming from, the
>> stack trace will always be the same, and it needlessly triggers things like
>> Abrt.  This changes the warning to just print a text warning about BIOS being
>> broken, without the stack trace, then sets the appropriate taint bit.  Since we
>> automatically disable irq remapping, theres no need to contiue making Abrt jump
>> at this problem
>>
>> Signed-off-by: Neil Horman <nhorman@...driver.com>
>> CC: Joerg Roedel <joro@...tes.org>
>> CC: Bjorn Helgaas <bhelgaas@...gle.com>
>> CC: Andy Lutomirski <luto@...capital.net>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
>> CC: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
>> ---
>>  drivers/iommu/intel_irq_remapping.c | 13 +++++++------
>>  1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
>> index f71673d..b97d70b 100644
>> --- a/drivers/iommu/intel_irq_remapping.c
>> +++ b/drivers/iommu/intel_irq_remapping.c
>> @@ -525,12 +525,13 @@ static int __init intel_irq_remapping_supported(void)
>>       if (disable_irq_remap)
>>               return 0;
>>       if (irq_remap_broken) {
>> -             WARN_TAINT(1, TAINT_FIRMWARE_WORKAROUND,
>> -                        "This system BIOS has enabled interrupt remapping\n"
>> -                        "on a chipset that contains an erratum making that\n"
>> -                        "feature unstable.  To maintain system stability\n"
>> -                        "interrupt remapping is being disabled.  Please\n"
>> -                        "contact your BIOS vendor for an update\n");
>> +             printk(KERN_WARNING
>> +                     "This system BIOS has enabled interrupt remapping\n"
>> +                     "on a chipset that contains an erratum making that\n"
>> +                     "feature unstable.  To maintain system stability\n"
>> +                     "interrupt remapping is being disabled.  Please\n"
>> +                     "contact your BIOS vendor for an update\n");
>> +             add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>               disable_irq_remap = 1;
>>               return 0;
>>       }
>> --
>> 1.8.3.1
>>
>>
>
> Ping Bjorn, Jeorg, any thoughts here?

This is in drivers/iommu, so I'd prefer that Joerg handle this.

My opinion is that this patch does the right thing in dropping the
backtrace and keeping the taint.

I tend to agree with Andy that we should also consider a second patch
that drops the taint, because this is basically just a quirk that
avoids broken chipset functionality, but as far as I can tell, there's
no reason to fear an undebuggable problem related to disabling
interrupt remapping.  We don't taint the kernel for other similar
quirks, so I don't see why we should here.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/