linux-kernel - Re: [PATCH] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 04 Oct 2013 12:22:32 +0200
From:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
To:	Jean-Francois Moine <moinejf@...e.fr>,
	Jason Cooper <jason@...edaemon.net>
CC:	Andrew Lunn <andrew@...n.ch>,
	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] ARM: Dove: fix bad properties of the si5351 clkout2 used
 by Cubox audio

On 10/04/2013 12:21 PM, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch inverts the properties of the clkout{1,2} so that clkout2
> may be defined as the external clock of the audio device in the Cubox.
>
> Signed-off-by: Jean-Francois Moine <moinejf@...e.fr>
> ---
>   arch/arm/boot/dts/dove-cubox.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index 022646e..5d1ece1 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -101,16 +101,16 @@
>
>   		clkout1 {
>   			reg = <1>;
> -			silabs,drive-strength = <8>;
>   			silabs,multisynth-source = <1>;
>   			silabs,clock-source = <0>;
> -			silabs,pll-master;
>   		};

Jean-Francois,

thanks for the patch! If we have no use for clkout1 at all on CuBox,
we can also remove the above completely.

For this or an updated patch which removes clkout1 completely:

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>

>   		clkout2 {
>   			reg = <2>;
> +			silabs,drive-strength = <8>;
>   			silabs,multisynth-source = <1>;
>   			silabs,clock-source = <0>;
> +			silabs,pll-master;
>   		};
>   	};
>   };
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/