linux-kernel - Re: [PATCH 1/2] regulator: wm8994: Remove redundant break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131004104702.GL27287@sirena.org.uk>
Date:	Fri, 4 Oct 2013 11:47:02 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] regulator: wm8994: Remove redundant break

On Fri, Oct 04, 2013 at 03:18:17PM +0530, Sachin Kamat wrote:

>  		default:
>  			return (selector * 100000) + 950000;
>  		}
> -		break;
>  	default:

I'm not sure this is actually a clarity improvement.  While the break is
redundant the return statements are all inside the nested switch so it's
not entirely obvious at a glance that all the paths were covered.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)