linux-kernel - [PATCH v2 2/2] input: rotary-encoder: Add 'on-each-step' to binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1380891203-17617-3-git-send-email-ezequiel@vanguardiasur.com.ar>
Date:	Fri,  4 Oct 2013 09:53:23 -0300
From:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
To:	<linux-kernel@...r.kernel.org>, <linux-input@...r.kernel.org>
Cc:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Daniel Mack <zonque@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <rob.herring@...xeda.com>,
	devicetree@...r.kernel.org
Subject: [PATCH v2 2/2] input: rotary-encoder: Add 'on-each-step' to binding documentation

The driver now supports a new mode to handle the interruptions generated
by the device: on this new mode an input event is generated on each step
(i.e. on each IRQ). Therefore, add a new DT property, to select the
mode: 'rotary-encoder,on-each-step'.

Cc: Daniel Mack <zonque@...il.com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Rob Herring <rob.herring@...xeda.com>
Cc: devicetree@...r.kernel.org
Signed-off-by: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
---
I'm not at all happy with this DT binding as it's way to customized
for the current driver. For instance, if we want to support mapping
key events (or better arbitrary linux-input event types) it seems
there's no easy way to fix the binding.

Maybe a better way of handling the different 'modes' is through
compatible strings?

I'm not really sure, so I hope the DT guys have some comment on this.

 Documentation/devicetree/bindings/input/rotary-encoder.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/input/rotary-encoder.txt b/Documentation/devicetree/bindings/input/rotary-encoder.txt
index 3315495..b89e38d 100644
--- a/Documentation/devicetree/bindings/input/rotary-encoder.txt
+++ b/Documentation/devicetree/bindings/input/rotary-encoder.txt
@@ -15,6 +15,7 @@ Optional properties:
 - rotary-encoder,rollover: Automatic rollove when the rotary value becomes
   greater than the specified steps or smaller than 0. For absolute axis only.
 - rotary-encoder,half-period: Makes the driver work on half-period mode.
+- rotary-encoder,on-each-step: Makes the driver send an event on each step.
 
 See Documentation/input/rotary-encoder.txt for more information.
 
-- 
1.8.1.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/