linux-kernel - Re: [PATCH] ftrace, sched: Add TRACE_FLAG_PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131004105342.20c00a41@gandalf.local.home>
Date:	Fri, 4 Oct 2013 10:53:42 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Yuanhan Liu <yuanhan.liu@...ux.intel.com>, mingo@...nel.org,
	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org,
	Fengguang Wu <fengguang.wu@...el.com>,
	Huang Ying <ying.huang@...el.com>, lkp@...ux.intel.com
Subject: Re: [PATCH] ftrace, sched: Add TRACE_FLAG_PREEMPT_RESCHED

On Fri, 4 Oct 2013 10:09:09 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> On Fri, Sep 27, 2013 at 05:29:08PM +0200, Peter Zijlstra wrote:
> > Subject: ftrace, sched: Add TRACE_FLAG_PREEMPT_RESCHED
> > From: Peter Zijlstra <peterz@...radead.org>
> > Date: Fri Sep 27 17:11:00 CEST 2013
> > 
> > Since we now have two need_resched states; trace the two so we can
> > observe discrepancies.
> > 
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Signed-off-by: Peter Zijlstra <peterz@...radead.org>
> 
> Steve, if you're done conferencing.. any objections?
> 

Taking a quick look, my only objection so far is that the change log is
rather flimsy. What are the two states and what are their dependencies?

In other words, what does these flags in the trace actually mean?
Probably need to add comments in the code and/or update the
Documentation section

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/