linux-kernel - Re: TPM.ko module rename (was tpm: Pull everything related to /dev/tpmX into tpm-dev.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1310041143060.32687@fishsauce>
Date:	Fri, 4 Oct 2013 11:45:43 -0500 (CDT)
From:	Ashley Lai <ashley@...leylai.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
cc:	Peter H?we <PeterHuewe@....de>, tpmdd-devel@...ts.sourceforge.net,
	Ashley Lai <ashley@...leylai.com>,
	Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, Rajiv Andrade <mail@...jiv.net>,
	Sirrix AG <tpmdd@...rix.com>
Subject: Re: TPM.ko module rename (was tpm: Pull everything related to
 /dev/tpmX into tpm-dev.c)



On Fri, 4 Oct 2013, Jason Gunthorpe wrote:

> On Fri, Oct 04, 2013 at 05:50:01PM +0200, Peter H?we wrote:
>
>> I'm not 100% sure what's the usual procedure for module renames, especially
>> since this is visible in userspace.
>>
>> For users the easiest way would be to rename tpm.c to tpm-core.c and
>> leave the module name as it is.  In git that's just a simple rename
>> operation.
>
> I agree, keeping the old name seems much safer.
>
> I'm thinking of following the pattern seen in RTC. Rename tpm.c to
> tpm-interface.c and eventually migrate all the driver model support
> items into tpm-class.c.
>
> Does that seem good? I'll respin the patches and test modular rebuilds.
>
> Jason
>

Me too, I vote to keep the same module name.  Please let me know 
when you are done with this patch, I would like to test it out.

Thanks,
--Ashley Lai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/