linux-kernel - Re: [PATCH] Remove redundant and incorrect memset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <524EFCFF.3000003@zytor.com>
Date:	Fri, 04 Oct 2013 10:38:07 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Roy Franz <roy.franz@...aro.org>, linux-kernel@...r.kernel.org,
	linux-efi@...r.kernel.org, matt.fleming@...el.com,
	msalter@...hat.com, patches@...aro.org
Subject: Re: [PATCH] Remove redundant and incorrect memset()

On 10/04/2013 10:33 AM, Ingo Molnar wrote:
> 
> * Roy Franz <roy.franz@...aro.org> wrote:
> 
>> Remove a redundant memset() call from efi_relocate_kernel() that
>> was clearing memory that would be used by BSS in non-compressed
>> images loaded with this function.  This clear was redundant with
>> the clearing done in the image itself, and also implemented incorrectly
>> with a 0 length.
>>
>> Signed-off-by: Roy Franz <roy.franz@...aro.org>
>> Acked-by: Mark Salter <msalter@...hat.com>
> 
> Note the title:
> 
>    [PATCH] Remove redundant and incorrect memset()
> 
> if it's both redundant *and* incorrect then the other memset() must be 
> incorrect too and must be removed as well ;-)
> 
> I suspect you wanted the title to say:
> 
>    [PATCH] Remove redundant memset()
> 

And more importantly:

[PATCH] boot,efi: Remove redundant memset()

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/