linux-kernel - Re: [PATCH] Remove redundant and incorrect memset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20131004173922.GA15959@gmail.com>
Date:	Fri, 4 Oct 2013 19:39:22 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Roy Franz <roy.franz@...aro.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Matt Fleming <matt.fleming@...el.com>,
	linux-efi@...r.kernel.org, patches@...aro.org, msalter@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Remove redundant and incorrect memset()

* Roy Franz <roy.franz@...aro.org> wrote:

> On Oct 4, 2013 1:33 PM, "Ingo Molnar" <mingo@...nel.org> wrote:
> >
> >
> > * Roy Franz <roy.franz@...aro.org> wrote:
> >
> > > Remove a redundant memset() call from efi_relocate_kernel() that
> > > was clearing memory that would be used by BSS in non-compressed
> > > images loaded with this function.  This clear was redundant with
> > > the clearing done in the image itself, and also implemented incorrectly
> > > with a 0 length.
> > >
> > > Signed-off-by: Roy Franz <roy.franz@...aro.org>
> > > Acked-by: Mark Salter <msalter@...hat.com>
> >
> > Note the title:
> >
> >    [PATCH] Remove redundant and incorrect memset()
> >
> > if it's both redundant *and* incorrect then the other memset() must be
> > incorrect too and must be removed as well ;-)
> >
> > I suspect you wanted the title to say:
> >
> >    [PATCH] Remove redundant memset()
> >
> > ?
> >
> > Thanks,
> >
> >         Ingo
> Hi Ingo,
> 
>   The memset being removed is redundant  with a correctly implemented
> memset in the kernel itself.   The memset being removed is also incorrect,
> with a hard coded length of 0.

So it was redundantly clearing nothing? ;-)

Anyway, I agree, the title makes sense.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/