linux-kernel - [PATCH]kconfig:mconf: avoid unneeded memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131005175715.GA28091@udknight>
Date:	Sun, 6 Oct 2013 01:57:15 +0800
From:	Wang YanQing <udknight@...il.com>
To:	mmarek@...e.cz
Cc:	linux-kbuild@...r.kernel.org, yann.morin.1998@...e.fr,
	bpoirier@...e.de, walch.martin@....de, jdelvare@...e.de,
	linux-kernel@...r.kernel.org
Subject: [PATCH]kconfig:mconf: avoid unneeded memcpy

In function update_text we assign jump key label
per page (1)-(9) cycled, and use three space char
as the header after k exceed JUMP_NB.

We don't need to call memcpy with header of three
space char, because it changes nothing, it just
copy what was there.

I don't think we need to clear old jump key label in
current implementation, I can't image out any case
which a search result could change its jump key label,
unless user search new string, but then we will re-assign
jump key label, and it will be fix after that.

Signed-off-by: Wang YanQing <udknight@...il.com>
---
 scripts/kconfig/mconf.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 2c39631..ff9d737 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -379,11 +379,8 @@ static void update_text(char *buf, size_t start, size_t end, void *_data)
 				data->keys[k] = key;
 				data->targets[k] = pos->target;
 				k++;
-			} else {
-				sprintf(header, "   ");
+				memcpy(buf + pos->offset, header, sizeof(header) - 1);
 			}
-
-			memcpy(buf + pos->offset, header, sizeof(header) - 1);
 		}
 	}
 	data->keys[k] = 0;
-- 
1.7.12.4.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/