linux-kernel - Re: [PATCH 2/5] drivers: usb: core: hcd: Whitespace fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380996319.2081.126.camel@joe-AO722>
Date:	Sat, 05 Oct 2013 11:05:19 -0700
From:	Joe Perches <joe@...ches.com>
To:	Matthias Beyer <mail@...ermatthias.de>
Cc:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] drivers: usb: core: hcd: Whitespace fixes

On Sat, 2013-10-05 at 11:04 -0700, Joe Perches wrote:
> On Sat, 2013-10-05 at 18:02 +0200, Matthias Beyer wrote:
> > - removing spaces before array indexing (foo [] to foo[])
> []
> > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> []
> > @@ -93,7 +93,7 @@ EXPORT_SYMBOL_GPL (usb_bus_list);
> >  /* used when allocating bus numbers */
> >  #define USB_MAXBUS		64
> >  struct usb_busmap {
> > -	unsigned long busmap [USB_MAXBUS / (8*sizeof (unsigned long))];
> > +	unsigned long busmap[USB_MAXBUS / (8*sizeof (unsigned long))];
> 
> this would be nicer as
> 
> 	DEFINE_BITMAP(busmap, USB_MAXBUS);
> 

nack, DECLARE_BITMAP(...)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/