| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <52505A7E.80802@ti.com>
Date: Sat, 5 Oct 2013 13:29:18 -0500
From: Joel Fernandes <joelf@...com>
To: Mark Rutland <mark.rutland@....com>
CC: Linux OMAP List <linux-omap@...r.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
Linux MMC List <linux-mmc@...r.kernel.org>,
Benoit Cousson <bcousson@...libre.com>,
Paul Walmsley <paul@...an.com>,
"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
Pawel Moll <Pawel.Moll@....com>,
Stephen Warren <swarren@...dotorg.org>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Rob Landley <rob@...dley.net>,
Tony Lindgren <tony@...mide.com>,
Russell King <linux@....linux.org.uk>,
"Mark A. Greer" <mgreer@...malcreek.com>,
"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
open list: DOCUMENTATION <linux-doc@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>, ;
Subject: Re: [PATCH v2 4/9] ARM: dts: Add AES data and documentation for AM33XX
These patches were not authored by me but I'll go ahead and fix them up anyway.
On 10/04/2013 09:33 AM, Mark Rutland wrote:
> On Mon, Sep 30, 2013 at 04:13:01PM +0100, Joel Fernandes wrote:
>> From: "Mark A. Greer" <mgreer@...malcreek.com>
>>
>> Add the generic AM33XX AES module's device tree data and
>> enable it for the am335x-evm, am335x-evmsk, and am335x-bone
>> platforms. Also add Documentation file describing the data
>> for the AES module.
>>
>> [joelf@...com: Dropped interrupt-parent propert]
>>
>> CC: Paul Walmsley <paul@...an.com>
>> Signed-off-by: Mark A. Greer <mgreer@...malcreek.com>
>> ---
>> .../devicetree/bindings/crypto/omap-aes.txt | 34 ++++++++++++++++++++++
>> arch/arm/boot/dts/am335x-bone.dts | 4 +++
>> arch/arm/boot/dts/am335x-evm.dts | 4 +++
>> arch/arm/boot/dts/am335x-evmsk.dts | 4 +++
>> arch/arm/boot/dts/am33xx.dtsi | 10 +++++++
>> 5 files changed, 56 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/omap-aes.txt b/Documentation/devicetree/bindings/crypto/omap-aes.txt
>> new file mode 100644
>> index 0000000..4bb1e27
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/crypto/omap-aes.txt
>> @@ -0,0 +1,34 @@
>> +OMAP SoC AES crypto Module
>> +
>> +Required properties:
>> +
>> +- compatible : Should contain entries for this and backward compatible
>> + AES versions:
>> + - "ti,omap2-aes" for OMAP2.
>> + - "ti,omap3-aes" for OMAP3.
>> + - "ti,omap4-aes" for OMAP4 and AM33XX.
>> + Note that the OMAP2 and 3 versions are compatible (OMAP3 supports
>> + more algorithms) but they are incompatible with OMAP4.
>> +- ti,hwmods: Name of the hwmod associated with the AES odule
>> +- reg : Offset and length of the register set for the module
>> +- interrupt-parent : the phandle for the interrupt controller that
>> + services interrupts for this module.
>> +- interrupts : the interrupt number for the AES odule.
>
> Similar comments to the SHAM module here:
>
> * s/interrupt number/interrupt-specifier/
> * Drop interrupt-parent.
> * s/AES odule/AES module/
Ok, done.
>> +
>> +Optional properties:
>> +- dmas: DMA specifier for tx and rx dma. See the DMA client binding,
>> + Documentation/devicetree/bindings/dma/dma.txt
>
> s/DMA specifier/DMA specifiers/
>
>> +- dma-names: DMA request names. Should be '"tx", "rx"' if dma is present.
>
> Nit: I'd prefer 'Should include "tx" and "rx" if present' -- I hope the
Ok, changed to the same.
> driver's requesting these by name rather than relying on a specific
> ordering (it makes future expansion and optional components far easier
> to handle sanely).
Yes, that's the case. Its handled by name using the
dma_request_slave_channel_compat API.
>> +
>> +Example:
>> + /* AM335x */
>> + aes: aes@...00000 {
>> + compatible = "ti,omap4-aes";
>> + ti,hwmods = "aes";
>> + reg = <0x53500000 0xa0>;
>> + interrupt-parent = <&intc>;
>> + interrupts = <102>;
>> + dmas = <&edma 6
>> + &edma 5>;
>> + dma-names = "tx", "rx";
>> + };
>
> Minor nit, but for consistency could you bracket the DMAs individually:
>
> dmas = <&edma 6>,
> <&edma 5>;
Ok changed as above.
>
>> diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
>> index 8a9802e..94ee427 100644
>> --- a/arch/arm/boot/dts/am335x-bone.dts
>> +++ b/arch/arm/boot/dts/am335x-bone.dts
>> @@ -23,3 +23,7 @@
>> &sham {
>> status = "okay";
>> };
>> +
>> +&aes {
>> + status = "okay";
>> +};
>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>> index d59e51c..86463fa 100644
>> --- a/arch/arm/boot/dts/am335x-evm.dts
>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>> @@ -526,3 +526,7 @@
>> &sham {
>> status = "okay";
>> };
>> +
>> +&aes {
>> + status = "okay";
>> +};
>> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
>> index d45a330..f577e65 100644
>> --- a/arch/arm/boot/dts/am335x-evmsk.dts
>> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
>> @@ -428,3 +428,7 @@
>> &sham {
>> status = "okay";
>> };
>> +
>> +&aes {
>> + status = "okay";
>> +};
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 299710b..0daa1b2 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -719,5 +719,15 @@
>> dmas = <&edma 36>;
>> dma-names = "rx";
>> };
>> +
>> + aes: aes@...00000 {
>> + compatible = "ti,omap4-aes";
>> + ti,hwmods = "aes";
>> + reg = <0x53500000 0xa0>;
>> + interrupts = <102>;
>> + dmas = <&edma 6
>> + &edma 5>;
>
> Bracketing here too, please.
Done.
Thanks,
-Joel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists