linux-kernel - Re: [PATCH 10/26] lustre: Convert ll_get_user_pages() to use get_user_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CE750CA8.75301%andreas.dilger@intel.com>
Date:	Sat, 5 Oct 2013 06:27:43 +0000
From:	"Dilger, Andreas" <andreas.dilger@...el.com>
To:	Jan Kara <jack@...e.cz>, LKML <linux-kernel@...r.kernel.org>
CC:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Greg Kroah-Hartman <greg@...ah.com>,
	Peng Tao <tao.peng@....com>,
	"hpdd-discuss@...ts.01.org" <hpdd-discuss@...ts.01.org>
Subject: Re: [PATCH 10/26] lustre: Convert ll_get_user_pages() to use
 get_user_pages_fast()

On 2013/10/02 8:27 AM, "Jan Kara" <jack@...e.cz> wrote:
>CC: Greg Kroah-Hartman <greg@...ah.com>
>CC: Peng Tao <tao.peng@....com>
>CC: Andreas Dilger <andreas.dilger@...el.com>
>CC: hpdd-discuss@...ts.01.org
>Signed-off-by: Jan Kara <jack@...e.cz>

Acked-by: Andreas Dilger <andreas.dilger@...el.com>

>---
> drivers/staging/lustre/lustre/llite/rw26.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/llite/rw26.c
>b/drivers/staging/lustre/lustre/llite/rw26.c
>index 96c29ad2fc8c..7e3e0967993b 100644
>--- a/drivers/staging/lustre/lustre/llite/rw26.c
>+++ b/drivers/staging/lustre/lustre/llite/rw26.c
>@@ -202,11 +202,8 @@ static inline int ll_get_user_pages(int rw, unsigned
>long user_addr,
> 
> 	OBD_ALLOC_LARGE(*pages, *max_pages * sizeof(**pages));
> 	if (*pages) {
>-		down_read(&current->mm->mmap_sem);
>-		result = get_user_pages(current, current->mm, user_addr,
>-					*max_pages, (rw == READ), 0, *pages,
>-					NULL);
>-		up_read(&current->mm->mmap_sem);
>+		result = get_user_pages_fast(user_addr, *max_pages,
>+					     (rw == READ), *pages);
> 		if (unlikely(result <= 0))
> 			OBD_FREE_LARGE(*pages, *max_pages * sizeof(**pages));
> 	}


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/