linux-kernel - Re: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u".

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52502E61.5000307@asianux.com>
Date:	Sat, 05 Oct 2013 23:21:05 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Al Viro <viro@...iv.linux.org.uk>,
	Thomas Gleixner <tglx@...utronix.de>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which
 express the maximize size of "%d" or "%u".

Hello Al Viro:

Is this patch correct?  ;-)

Thanks.

On 10/05/2013 11:19 PM, Chen Gang wrote:
> Theoretically, the maximize size of "%d" or "%u" is 11 (10 + '\0'), so
> need set MAX_NAMELEN 11 instead of 10.
> 
> In real world, it may not cause issue, but still recommend to fix this
> 'theoretical' bug (especially original definition already considered
> about 'theoretical' using).
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  kernel/irq/proc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
> index 36f6ee1..4e9a9ee 100644
> --- a/kernel/irq/proc.c
> +++ b/kernel/irq/proc.c
> @@ -305,7 +305,7 @@ void register_handler_proc(unsigned int irq, struct irqaction *action)
>  
>  #undef MAX_NAMELEN
>  
> -#define MAX_NAMELEN 10
> +#define MAX_NAMELEN 11
>  
>  void register_irq_proc(unsigned int irq, struct irq_desc *desc)
>  {
> 


-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/