linux-kernel - Re: [PATCH 1/2] tpm: Rename tpm.c to tpm-interface.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131006201529.GA10426@obsidianresearch.com>
Date:	Sun, 6 Oct 2013 14:15:29 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Peter H?we <PeterHuewe@....de>, tpmdd-devel@...ts.sourceforge.net,
	Ashley Lai <ashley@...leylai.com>,
	Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, Rajiv Andrade <mail@...jiv.net>,
	Sirrix AG <tpmdd@...rix.com>
Subject: Re: [PATCH 1/2] tpm: Rename tpm.c to tpm-interface.c

On Sun, Oct 06, 2013 at 12:53:22PM -0700, Joe Perches wrote:
> On Sun, 2013-10-06 at 13:38 -0600, Jason Gunthorpe wrote:
> > This is preparation for making the tpm module multi-file. kbuild does
> > not like having a .c file with the same name as a module. We wish to
> > keep the tpm module name so that userspace doesn't see this change.
> 
> If that's true, and I don't believe it is,
> then Kbuild should be fixed instead.
> 
> There are a lot of examples of .c files named
> the same as the directory they reside in.

That isn't the trouble, it is having a module named tpm, comprised of
tpm.c, tpm-foo.c, and tpm-bar.c

The issue is that assembling the tpm module uses tpm.o as an
intermediate file, and compiling tmp.c uses tpm.o as a intermediate
file - they conflict, things don't work right and make throws a
circular dependency warning.

The Makefile I started with looks like this:

obj-m += tpm.o
tpm-y := tpm.o tpm-foo.o tpm-bar.o

Is there some other solution?

In any event, this patch is part of a series that splits tpm.c up,
renaming it at this point in the series is to make kbuild work, but
at the end of the series it should be renamed anyhow :)

Regards,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/