linux-kernel - Re: Preferred line-break style around binary operators?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131006221116.GR19510@leaf>
Date:	Sun, 6 Oct 2013 15:11:16 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Joe Perches <joe@...ches.com>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: Preferred line-break style around binary operators?

On Sun, Oct 06, 2013 at 03:01:26PM -0700, Joe Perches wrote:
> On Sun, 2013-10-06 at 14:48 -0700, Josh Triplett wrote:
> > There are two common approaches to breaking long lines at binary
> > operators: breaking the line before the operator (putting the operator
> > at the start of the next line), or breaking the line after the operator
> > (putting the operator at the end of the previous line).
> > 
> > CodingStyle doesn't define any requirement here, and the kernel uses
> > both approaches; for instance, using && as a sample:
> > 
> > $ git grep -h '&&$' | wc -l
> > 28872
> > $ git grep -h '^[[:space:]]*&&' | wc -l
> > 4169
> > 
> > Which style should kernel code use?  I can submit a CodingStyle patch
> > documenting that preference for future reference.
> 
> That was pretty contentious awhile ago.
> An example:
> https://lkml.org/lkml/2009/12/5/30
> 
> net/ and drivers/net/ use && and || at EOL.

It appears that the vast majority of kernel code does the same, judging
by the grep above.

Personally I prefer to put binary operators at the start of the
following line, but my preference isn't the deciding factor here.

I'd just like to see one or the other style documented as preferred in
CodingStyle for future reference, rather than having new kernel code
continue to use a mix of both styles.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/