[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131006235702.GA21738@srcf.ucam.org>
Date: Mon, 7 Oct 2013 00:57:02 +0100
From: Matthew Garrett <mjg59@...f.ucam.org>
To: Felipe Contreras <felipe.contreras@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] acpi: update win8 OSI blacklist
On Sun, Oct 06, 2013 at 06:36:57PM -0500, Felipe Contreras wrote:
> On Sun, Oct 6, 2013 at 6:31 PM, Matthew Garrett <mjg59@...f.ucam.org> wrote:
> > On Sun, Oct 06, 2013 at 06:27:28PM -0500, Felipe Contreras wrote:
> >> From acpi_osi_dmi_table:
> >>
> >> /*
> >> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
> >> * Linux ignores it, except for the machines enumerated below.
> >> */
> >
> > Which was a mistake. We learn from mistakes rather than repeating them.
>
> According to you.
Cool. Look at that file and, without resorting to git blame, tell me
why each of those entries is there. If your answer is "Just use git
blame", then that's fine up until the point where someone reformats the
list or decides to change the order and now it's still *possible* it's
just really annoying, so why not just add the comments? They're cheap
and you could have done it trivially in the time it's taken you to reply
to this thread.
--
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists