linux-kernel - Re: [PATCH] acpi: update win8 OSI blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131007012704.GA22371@srcf.ucam.org>
Date:	Mon, 7 Oct 2013 02:27:04 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] acpi: update win8 OSI blacklist

On Sun, Oct 06, 2013 at 08:01:34PM -0500, Felipe Contreras wrote:
> On Sun, Oct 6, 2013 at 7:53 PM, Matthew Garrett <mjg59@...f.ucam.org> wrote:
> > No, it demonstrably doesn't. The comments that do exist refer to only a
> > subset of the entries underneath them.
> 
> That's not true.
> 
> /*
> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
> * Linux ignores it, except for the machines enumerated below.
> */

You appear to have missed the continuation of that comment directly 
underneath which lists a subset of the devices covered by the quirks.

> > Having a per-entry comment is significantly clearer.
> 
> That is your opinion, it's not a demonstrable fact.

Say one of the machines turns out to need the quirk for two different 
reasons. How do we document that? Look, how about you add the comments 
and I'll do a patch that adds documentation to the existing entries? I'm 
not asking you to make up for other people's past mistakes, I'm asking 
you not to perpetuate them.

> And just to be clear, you are saying that in the following code, you
> have no idea which statements correspond to which sections. Am I
> correct?

No, that's not what I'm saying. But I'm now going to a bar and drink 
instead of having to justify why *clearly documenting this code* is a 
worthwhile thing to do.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/