linux-kernel - Re: [PATCH] thermal: offer TI thermal support only when ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <24683815.qjRRgfGo3Z@amdc1032>
Date:	Mon, 07 Oct 2013 12:05:05 +0200
From:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:	Eduardo Valentin <eduardo.valentin@...com>
Cc:	Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] thermal: offer TI thermal support only when ARCH_OMAP2PLUS
 is defined

On Friday, October 04, 2013 02:26:54 PM Eduardo Valentin wrote:
> On 04-10-2013 14:22, Eduardo Valentin wrote:
> > On 04-10-2013 08:35, Bartlomiej Zolnierkiewicz wrote:
> >> Menu for Texas Instruments thermal support is visible on all
> >> platforms and TI_SOC_THERMAL + TI_THERMAL config options can
> >> be selected also on EXYNOS platform (on which ARCH_HAS_BANDGAP
> >> config option is selected by SoCs config options to fulfill
> >> EXYNOS_THERMAL config option dependency). Thus the code which
> >> is never used can be build. Fix it by making TI menu dependent
> >> on ARCH_OMAP2PLUS config option.
> >>
> 
> 
> Besides, you can always disable the driver if you are not interested in
> compiling it.

You should not have TI-specific drivers visible without any TI dependencies.
ARCH_BANDGAP dependency is not enough, ARCH_BANDGAP is also used by EXYNOS
to indicate thermal support. Currently you can select TI thermal drivers on
EXYNOS platforms without any other dependencies on TI. This is just wrong,
it can result in unused code being build currently but can result in more
severe problems in the future (build break).

> >> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> >> ---
> >>  drivers/thermal/Kconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> >> index 57e06a9..a709c63 100644
> >> --- a/drivers/thermal/Kconfig
> >> +++ b/drivers/thermal/Kconfig
> >> @@ -193,6 +193,7 @@ config X86_PKG_TEMP_THERMAL
> >>  	  notification methods.
> >>  
> >>  menu "Texas Instruments thermal drivers"
> >> +depends on ARCH_OMAP2PLUS
> > 
> > No, this driver is not for ARCH_OMAP*, but for TI bandgap, with the
> > option to offer thermal control. So, the HW supported is TI bandgap IP,
> > not ARCH_OMAP*. It happens to be so that OMAP2PLUS all have a
> > (different) version of this device.
> > 
> > However, DRA7 devices, for instance, also feature the bandgap IP
> > (different version of those present in OMAP devices), and it is not
> > ARCH_OMAP2PLUS.
> > 
> > And because of that, the design of this driver is different. It is not
> > expected to depend on an arch, but the arch code is expected to select
> > ARCH_HAS_BANDGAP.
> > 
> >>  source "drivers/thermal/ti-soc-thermal/Kconfig"
> >>  endmenu

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/