linux-kernel - Re: [PATCH] MIPS: SmartMIPS: Fix build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5252D343.6090100@imgtec.com>
Date:	Mon, 7 Oct 2013 16:29:07 +0100
From:	Markos Chandras <Markos.Chandras@...tec.com>
To:	Thierry Reding <thierry.reding@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>
CC:	<linux-mips@...ux-mips.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MIPS: SmartMIPS: Fix build

On 10/07/13 16:10, Thierry Reding wrote:
> All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
> the ACX register declaration in struct pt_regs is still protected by it,
> causing builds to fail. Remove the #ifdef protection and always declare
> the register.
>
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>   arch/mips/include/asm/ptrace.h | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7bba9da..d47bdce 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -33,9 +33,7 @@ struct pt_regs {
>   	unsigned long cp0_status;
>   	unsigned long hi;
>   	unsigned long lo;
> -#ifdef CONFIG_CPU_HAS_SMARTMIPS
>   	unsigned long acx;
> -#endif
>   	unsigned long cp0_badvaddr;
>   	unsigned long cp0_cause;
>   	unsigned long cp0_epc;
>

Hi Thierry,

Looks good to me. Thanks!

Reviewed-by: Markos Chandras <markos.chandras@...tec.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/