linux-kernel - Re: [PATCH/RFC] clocksource: Consolidate SH and ARM mach-shmobile Kconfig bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131007163726.GC15413@quad.lixom.net>
Date:	Mon, 7 Oct 2013 09:37:26 -0700
From:	Olof Johansson <olof@...om.net>
To:	Simon Horman <horms@...ge.net.au>
Cc:	Magnus Damm <magnus.damm@...il.com>, linux-sh@...r.kernel.org,
	khilman@...aro.org, arnd@...db.de, daniel.lezcano@...aro.org,
	linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH/RFC] clocksource: Consolidate SH and ARM mach-shmobile
 Kconfig bits

On Fri, Sep 27, 2013 at 01:43:25PM +0900, Simon Horman wrote:
> On Thu, Sep 26, 2013 at 08:37:09AM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm@...nsource.se>
> > 
> > Based on request from Olof Johansson, move ARM mach-shmobile
> > clocksource entries to drivers/clocksource/Kconfig, and at
> > the same time make the SH architecture use these entries.
> > 
> > Kconfig entries for CMT, MTU2, TMU and STI are with this patch
> > now kept in one place. The SH SYS_SUPPORTS_nnn bits are dropped
> > to simplye let the user select the appropriate ones using Kconfig
> > instead of trying to filter available timers based on SoC.
> > 
> > Known issues:
> >  1) Not yet wrappend in menu/endmenu, populates the root driver menu
> >  -> proposal: Create separate patch to wrap all the clocksource entries?
> 
> That seems reasonable to me.
> 
> >  2) Should the entries be sorted?
> >  -> proposal: Ignore cosmetic bits
> 
> I propose that you sort the entries are adding
> but leave the rest of the entries as is.
> 
> >  3) What is correct dependency for multiplatform and single platform?
> >  -> proposal: Perhaps we should simply default to no?
> 
> I'm not sure that I understand the issue here.
> 
> >  4) Is single patch across 2 architectures and drivers/clocksource OK?
> >  -> proposal: Keep it like this if possible
> 
> Olof, I would like your opinion on this but from my pov this seems
> reasonable. Especially as one of the architectures (sh) is seeing very little
> change at this time.

(Sorry for the delayed response, the renesas volume email can be large and
I don't always read it when it comes in).


Yeah, as long as you have appropriate acks and don't expect conflicts.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/