linux-kernel - Re: [PATCH] memstick: Fix memory leak in memstick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525227C0.6040601@lwfinger.net>
Date:	Sun, 06 Oct 2013 22:17:20 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Alex Dubov <oakad@...oo.com>,
	Catalin Marinas <catalin.marinas@....com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] memstick: Fix memory leak in memstick_check() error path

On 10/06/2013 08:57 PM, Alex Dubov wrote:
> Hi,
>
> In the good old times, when this driver was first written, device name used to be a fixed
> size array (of 32 chars, if I'm not mistaken) in the kobj struct, so there was no need to
> free it explicitly.
>
> Since than, somebody changed the name field to become a loose pointer, but it's not
> obvious how it is supposed to be handled these days.

It has been some time since it was changed. In commit af5ca3f by Kay Sievers and 
merged on Dec 20, 2007, "const char *k_name" was changed to "const char *name". 
I did not go any further back.

I'll submit V2 of my patch for further comment.

Larry



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/