linux-kernel - Re: [PATCH] 9p: unsigned/signed wrap in p9/unix modes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGG-pUQJCGcY=hAobBodH-dTLLohUpe6KJbuMvwWkhdt3RSk+A@mail.gmail.com>
Date:	Mon, 7 Oct 2013 21:18:11 -0300
From:	Geyslan Gregório Bem <geyslan@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Eric Van Hensbergen <ericvh@...il.com>, rminnich@...dia.gov,
	lucho@...kov.net, v9fs-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	kernel-br <kernel-br@...glegroups.com>
Subject: Re: [PATCH] 9p: unsigned/signed wrap in p9/unix modes.

Joe,

Nice, I'll wait their reply, there are other p9 patches that I have
already sent and am awaiting Eric's.

Thank you again.

Geyslan Gregório Bem
hackingbits.com


2013/10/7 Joe Perches <joe@...ches.com>:
> On Mon, 2013-10-07 at 21:09 -0300, Geyslan Gregório Bem wrote:
>> Joe,
>>
>> Thank you for reply.
>>
>> What do you think about:
>>
>>                  strncpy(ext, stat->extension, sizeof(ext));
>> +                 if (sscanf(ext, "%c %u %u", &type, &major, &minor) < 3) {
>> +                                  p9_debug(P9_DEBUG_ERROR,
>> +                                  "It's necessary define type, major
>> and minor values when using P9_DMDEVICE");
>> +                                  return res;
>> +                 }
>>                  switch (type) {
>>                  case 'c':
>>                          res |= S_IFCHR;
>>                          break;
>> ...
>>                  *rdev = MKDEV(major, minor);
>
> I think the plan 9 folk should figure out what's right.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/