linux-kernel - Re: [PATCH 26/50] tools/perf/build: Split out feature check: 'libbfd'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131008081558.GB6706@gmail.com>
Date:	Tue, 8 Oct 2013 10:15:58 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	David Ahern <dsahern@...il.com>, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH 26/50] tools/perf/build: Split out feature check: 'libbfd'


* Jiri Olsa <jolsa@...hat.com> wrote:

> On Mon, Oct 07, 2013 at 09:11:15AM -0600, David Ahern wrote:
> > On 10/7/13 5:56 AM, Ingo Molnar wrote:
> > >diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> > >index 77a2e6b..4f60ecc 100644
> > >--- a/tools/perf/config/Makefile
> > >+++ b/tools/perf/config/Makefile
> > >@@ -121,6 +121,7 @@ FEATURE_TESTS =				\
> > >  	libperl				\
> > >  	libpython			\
> > >  	libpython-version		\
> > >+	libbfd				\
> > >  	libnuma
> > >
> > >  $(foreach test,$(FEATURE_TESTS),$(call feature_check,$(test),$(test)))
> > 
> > strlcpy missing from FEATURE_TESTS, but really the strlcpy changes
> > should be a separate patch.

Indeed, that's an oversight.

> it gets removed completely in here:
>   tools/perf: Turn strlcpy() into a __weak function
> 
> still I think David's right and there should be
> separate patch for strlcpy check

Ok, I have created a separate patch for that, so that's logically 
consistent.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/