linux-kernel - Re: [PATCH 44/50] tools/perf/build: Collapse the test-all.c testcase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131008084730.GC3295@gmail.com>
Date:	Tue, 8 Oct 2013 10:47:30 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 44/50] tools/perf/build: Collapse the test-all.c testcase


* Jiri Olsa <jolsa@...hat.com> wrote:

> On Mon, Oct 07, 2013 at 01:56:37PM +0200, Ingo Molnar wrote:
> 
> SNIP
> 
> > diff --git a/tools/perf/config/feature-checks/test-backtrace.c b/tools/perf/config/feature-checks/test-backtrace.c
> > index 6a5fd96..5b33bcf 100644
> > --- a/tools/perf/config/feature-checks/test-backtrace.c
> > +++ b/tools/perf/config/feature-checks/test-backtrace.c
> > @@ -9,8 +9,6 @@ int main(void)
> >  	entries = backtrace(backtrace_fns, 10);
> >  	backtrace_symbols_fd(backtrace_fns, entries, 1);
> >  
> > -	printf("backtrace entries: %d\n", entries);
> > - 
> >  	return 0;
> 
> belongs to previous patch?

Yes.

> 
> >  }
> >  
> > diff --git a/tools/perf/config/feature-checks/test-libunwind.c b/tools/perf/config/feature-checks/test-libunwind.c
> > index 088fc59..43b9369 100644
> > --- a/tools/perf/config/feature-checks/test-libunwind.c
> > +++ b/tools/perf/config/feature-checks/test-libunwind.c
> > @@ -18,9 +18,10 @@ int main(void)
> >  
> >  	addr_space = unw_create_addr_space(&accessors, 0);
> >  	if (addr_space)
> > -		return;
> > +		return 0;
> >  
> >  	unw_init_remote(NULL, addr_space, NULL);
> >  	dwarf_search_unwind_table(addr_space, 0, NULL, NULL, 0, NULL);
> > +
> 
> ditto

Thanks, fixed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/