linux-kernel - [PATCH] BUS: CCI : Fix arm-cci implicit declarations dependence errors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue,  8 Oct 2013 16:04:09 +0530
From:	Majunath Goudar <csmanjuvijay@...il.com>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	nataraja.km@....com, Majunath Goudar <csmanjuvijay@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Alexander Shiyan <shc_work@...l.ru>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] BUS: CCI : Fix arm-cci implicit declarations dependence errors.

This patch adds a OF dependency to configure the ARM_CCI in drivers/bus/Kconfig.
Without this patch, build system can lead to build failure. This was observed
during randconfig testing, in which ARM_CCI was enabled w/o OF being enabled.
Following was the error:

CC      drivers/bus/arm-cci.o
drivers/bus/arm-cci.c: In function ‘cci_ace_init_ports’:
drivers/bus/arm-cci.c:131:2: error: implicit declaration of function
‘of_find_node_by_path’ [-Werror=implicit-function-declaration]
  cpus = of_find_node_by_path("/cpus");
  ^
drivers/bus/arm-cci.c:131:7: warning: assignment makes pointer from integer
without a cast [enabled by default]
  cpus = of_find_node_by_path("/cpus");
       ^
cc1: some warnings being treated as errors
make[2]: *** [drivers/bus/arm-cci.o] Error 1
make[1]: *** [drivers/bus] Error 2

Signed-off-by: Manjunath Goudar <csmanjuvijay@...il.com>
Cc: Tony Lindgren <tony@...mide.com>
Cc: Shawn Guo <shawn.guo@...aro.org>
Cc: Arnd Bergmann <arnd@...db.de>
Cc: Alexander Shiyan <shc_work@...l.ru>
Cc: linux-kernel@...r.kernel.org
---
 drivers/bus/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 552373c..e522bd6 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -37,7 +37,7 @@ config OMAP_INTERCONNECT
 
 config ARM_CCI
 	bool "ARM CCI driver support"
-	depends on ARM
+	depends on ARM && OF
 	help
 	  Driver supporting the CCI cache coherent interconnect for ARM
 	  platforms.
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/