linux-kernel - [PATCH] SHMOBILE: DRM: Fix backlight_device register and unregister undefined errors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue,  8 Oct 2013 16:09:17 +0530
From:	Majunath Goudar <csmanjuvijay@...il.com>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	nataraja.km@....com, Majunath Goudar <csmanjuvijay@...il.com>,
	David Airlie <airlied@...ux.ie>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH] SHMOBILE: DRM: Fix backlight_device register and unregister undefined errors.

This patch adds a BACKLIGHT_CLASS_DEVICE dependency to configure the
DRM_SHMOBILE. Without this patch, build system can lead to build failure.
This was observed during randconfig testing, in which DRM_SHMOBILE was
enabled w/o BACKLIGHT_CLASS_DEVICE being enabled. Following was the error:

 Building modules, stage 2.
  MODPOST 516 modules
ERROR: "backlight_device_register" [drivers/gpu/drm/shmobile/shmob-drm.ko] undefined!
ERROR: "backlight_device_unregister" [drivers/gpu/drm/shmobile/shmob-drm.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Signed-off-by: Manjunath Goudar <csmanjuvijay@...il.com>
Cc: David Airlie <airlied@...ux.ie>
Cc: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Cc: Sascha Hauer <s.hauer@...gutronix.de>
Cc: dri-devel@...ts.freedesktop.org
Cc: linux-kernel@...r.kernel.org
---
 drivers/gpu/drm/shmobile/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
index ca498d1..eaf822e 100644
--- a/drivers/gpu/drm/shmobile/Kconfig
+++ b/drivers/gpu/drm/shmobile/Kconfig
@@ -1,6 +1,6 @@
 config DRM_SHMOBILE
 	tristate "DRM Support for SH Mobile"
-	depends on DRM && (ARM || SUPERH)
+	depends on DRM && (ARM || SUPERH) && BACKLIGHT_CLASS_DEVICE
 	select DRM_KMS_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/