linux-kernel - Re: perf: perf sched lat segfault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Oct 2013 12:51:13 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Mike Galbraith <bitbucket@...ine.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: perf: perf sched lat segfault - bisected

Mike,

I posted the fix now. It was somewhere else. But you got the idea.
thanks for reporting the problem.

On Tue, Oct 8, 2013 at 12:50 PM, Mike Galbraith <bitbucket@...ine.de> wrote:
> On Tue, 2013-10-08 at 12:36 +0200, Stephane Eranian wrote:
>> Mike,
>>
>> I found the problem in perf. The tool->mmap2 pointer is NULL for sched tool.
>> Let me send you a patch to fix this.
>
> Ah, no need.  It's probably something like so, which fixed it.
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index d8c51b2f263f..a60d14dd18e7 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1658,6 +1658,7 @@ static struct perf_sched sched = {
>                 .comm            = perf_event__process_comm,
>                 .lost            = perf_event__process_lost,
>                 .fork            = perf_sched__process_fork_event,
> +               .mmap2           = perf_event__process_mmap2,
>                 .ordered_samples = true,
>         },
>         .cmp_pid              = LIST_HEAD_INIT(sched.cmp_pid),
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/