linux-kernel - Re: mmap for /proc/vmcore broken since 3.12-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVxJT8S7kA92=80DWVmVJJvbnaQ6WkyvsiFq4wP37WHV=tfuA@mail.gmail.com>
Date:	Tue, 8 Oct 2013 15:49:54 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	HATAYAMA Daisuke <d.hatayama@...fujitsu.com>
Cc:	Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
	"David S. Miller" <davem@...emloft.net>,
	Vivek Goyal <vgoyal@...hat.com>,
	Jan Willeke <willeke@...ibm.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	kexec@...ts.infradead.org
Subject: Re: mmap for /proc/vmcore broken since 3.12-rc1

On Mon, Oct 7, 2013 at 5:42 AM, HATAYAMA Daisuke
<d.hatayama@...fujitsu.com> wrote:

> +static unsigned long
> +get_unmapped_area_vmcore(struct file *filp, unsigned long addr,
> +                        unsigned long len, unsigned long pgoff,
> +                        unsigned long flags)
> +{
> +#ifdef CONFIG_MMU
> +       return current->mm->get_unmapped_area(filp, addr, len, pgoff,
> flags);
> +#else
> +       return -EIO;
> +#endif
> +}
> +
>  static const struct file_operations proc_vmcore_operations = {
>         .read           = read_vmcore,
>         .llseek         = default_llseek,
>         .mmap           = mmap_vmcore,
> +       .get_unmapped_area = get_unmapped_area_vmcore,

I think current->mm->get_unmapped_area should be used by core proc code.
ENOMEM bug looks unrelated though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/